[exporter/googlemanagedprometheusexporter] correct zone #26242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The zone `us-east-1` is not a valid GCP zone, which causes writing metrics with this processors to fail. `us-east-1` is the AWS region, which means `aws:us-east-1` would work, but this commit changes this to the GCP equivalent `us-east1`.
github-actions
bot
added
the
exporter/googlemanagedprometheus
dashpole
approved these changes
Aug 28, 2023
|
Thanks! |
dashpole
added
Skip Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The zone
us-east-1is not a valid GCP zone, which causes writing metrics with this example processor to fail.us-east-1is the AWS region, which meansaws:us-east-1would work, but this PR changes this to the GCP equivalentus-east1.